Scufl 2
  1. Scufl 2
  2. SCUFL2-87

Invalid names should not be allowed

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.13.2
  • Component/s: Beans API
  • Labels:
    None

Description

There is no restriction on the String that can be used as the name for a Named. This does not seem sensible as there have already been problems in Taverna 1 and 2 with weirdly named objects. Previously, any constraints were implicitly enforced by the workbench UI. This is no longer possible.

It would be better if there were restrictions on the name e.g. that it is alphanumeric.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Stian Soiland-Reyes added a comment -

The scufl2 code itself and the workflow bundle serialization can cope with any kind of name (up to a reasonable size), as it is escaped where needed.

Practically though, I agree. The name of workflow bean is meant to be used somewhat similar to a variable name in programming, and so should not be a big essay or contain control characters. It is however important to upport international Unicode characters as we should not require workflows to be built in English.

It is however out of scope for SCUFL2 to restrict names based on for instance how the workflow would be serialized as SVG within the Taverna Workbench - that could be a moving target.

I am leaving this open, as a minimum characters such as "/" and "\n" should not be allowed. A maximum length of say 128 might be sensible.

Show
Stian Soiland-Reyes added a comment - The scufl2 code itself and the workflow bundle serialization can cope with any kind of name (up to a reasonable size), as it is escaped where needed. Practically though, I agree. The name of workflow bean is meant to be used somewhat similar to a variable name in programming, and so should not be a big essay or contain control characters. It is however important to upport international Unicode characters as we should not require workflows to be built in English. It is however out of scope for SCUFL2 to restrict names based on for instance how the workflow would be serialized as SVG within the Taverna Workbench - that could be a moving target. I am leaving this open, as a minimum characters such as "/" and "\n" should not be allowed. A maximum length of say 128 might be sensible.
Hide
Permalink
Stian Soiland-Reyes added a comment -

":" in workflow (and processor) name breaks the invocation monitor, because : is used as separator in the Owning Process ID.

Show
Stian Soiland-Reyes added a comment - ":" in workflow (and processor) name breaks the invocation monitor, because : is used as separator in the Owning Process ID.
Hide
Permalink
Stian Soiland-Reyes added a comment -

Fixed

Show
Stian Soiland-Reyes added a comment - Fixed
Hide
Permalink
Jenkins Automated build added a comment -

UNSTABLE: Integrated in scufl2 #4103
SCUFL2-87: Disallow certain invalid characters in name (stian: 9655bbd30af19b33bedabcf39eb892d2b18c1841)

  • scufl2-api/src/main/java/uk/org/taverna/scufl2/api/common/Named.java
  • scufl2-api/src/main/java/uk/org/taverna/scufl2/api/common/AbstractNamed.java
  • scufl2-api/src/test/java/uk/org/taverna/scufl2/api/common/TestAbstractNamed.java
Show
Jenkins Automated build added a comment - UNSTABLE: Integrated in scufl2 #4103 SCUFL2-87: Disallow certain invalid characters in name (stian: 9655bbd30af19b33bedabcf39eb892d2b18c1841 ) scufl2-api/src/main/java/uk/org/taverna/scufl2/api/common/Named.java scufl2-api/src/main/java/uk/org/taverna/scufl2/api/common/AbstractNamed.java scufl2-api/src/test/java/uk/org/taverna/scufl2/api/common/TestAbstractNamed.java
Hide
Permalink
Jenkins Automated build added a comment -

FAILURE: Integrated in scufl2 #4148
SCUFL2-87: Disallow certain invalid characters in name (stian: rev 9655bbd30af19b33bedabcf39eb892d2b18c1841)

  • scufl2-api/src/test/java/uk/org/taverna/scufl2/api/common/TestAbstractNamed.java
  • scufl2-api/src/main/java/uk/org/taverna/scufl2/api/common/AbstractNamed.java
  • scufl2-api/src/main/java/uk/org/taverna/scufl2/api/common/Named.java
Show
Jenkins Automated build added a comment - FAILURE: Integrated in scufl2 #4148 SCUFL2-87: Disallow certain invalid characters in name (stian: rev 9655bbd30af19b33bedabcf39eb892d2b18c1841) scufl2-api/src/test/java/uk/org/taverna/scufl2/api/common/TestAbstractNamed.java scufl2-api/src/main/java/uk/org/taverna/scufl2/api/common/AbstractNamed.java scufl2-api/src/main/java/uk/org/taverna/scufl2/api/common/Named.java

People

  • Assignee:
    Stian Soiland-Reyes
    Reporter:
    Alan Williams
  • Votes:
    0 Vote for this issue
    Watchers:
    2 Start watching this issue

Dates

  • Created:
    Updated:
    Resolved: