Sysmo DB
  1. Sysmo DB
  2. SYSMO-1085

Model Image routes and controllers are messed up

    Details

    • Type: Bug Bug
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      e.g. there is the route to the image:
      https://testing.sysmo-db.org/models/send_image/44?version=1

      which should be models/44/image?version=1 to follow the standard URL scheme.
      There is an model_images_controller that contains actions that as far as I can tell are never used.

      All needs deciphering and tidying up, fixing the routes, making the model_images_controller nested if necessary, and removing unnessary actions and views

        Issue Links

          Activity

          Hide
          Stuart Owen added a comment -

          Seems the model_images_controller and the dual has_many :model_images and belongs_to :model_image in Model is to allow new images to be uploaded whilst retaining the ability to revert to an older image, whereas the normal handing of model_images is hall handled in models_controller leading.

          I think the ability to switch images is an unnecessary over complication and can be removed - and creation of new images should either be handled ONLY in the models_controller or ONLY in the models_image_controller

          Show
          Stuart Owen added a comment - Seems the model_images_controller and the dual has_many :model_images and belongs_to :model_image in Model is to allow new images to be uploaded whilst retaining the ability to revert to an older image, whereas the normal handing of model_images is hall handled in models_controller leading. I think the ability to switch images is an unnecessary over complication and can be removed - and creation of new images should either be handled ONLY in the models_controller or ONLY in the models_image_controller

            People

            • Assignee:
              Stuart Owen
              Reporter:
              Stuart Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated: