myGrid
  1. myGrid
  2. TAV-721

T2 Valdation fails for processors containing merged ports.

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.7.1
    • Component/s: None
    • Labels:
      None

      Description

      If a workflow contains a port with multiple inputs set to "Merge" then the workflow succesfully translates to a T2 dataflow, but subsequently fails to validate.
      This is because the merge is being handled by inserting a new node in the dataflow, which isn't a Processor but a TokenProcessorEntity causing it to be skipped during the type checking phase.
      This fix for this looks like it should be to move the doTypeCheck from Processor to TokenProcessorEntity, and have the type checking run over all TokenProcessingEntities.

      I've added an integration test that flags this problem: TranslateAndRunTest::testTranslateAndValidateWithMerge which currently fails.

        Activity

        Hide
        Stuart Owen added a comment -

        This has now been fixed.

        Show
        Stuart Owen added a comment - This has now been fixed.

          People

          • Assignee:
            Stuart Owen
            Reporter:
            Stuart Owen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: